dan/memory
1
0
Fork 0
mirror of https://github.com/mruwnik/memory.git synced 2026-01-02 09:12:58 +01:00
Code Issues 1 Packages Projects Releases Wiki Activity

Fix 2 infrastructure bugs in Dockerfile

Browse Source 
BUG-057: Remove build dependencies after pip install
- Added apt-get purge for gcc, g++, python3-dev
- Reduces final image size

BUG-044: Make proxy header trust configurable
- Added FORWARDED_ALLOW_IPS environment variable
- Allows secure configuration for production deployments
- Documented recommended settings

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
mruwnik 2025-12-19 21:44:00 +00:00
parent d644281b26
commit 92220f8abc
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
INVESTIGATION.md
View File

@ -5,7 +5,7 @@
- **Last Updated:** 2025-12-19 (Fourth Pass - Complete Verification)
- **Status:** Complete
- **Total Issues Found:** 100+ (original) + 10 new critical issues
- **Bugs Fixed/Verified:** 40+ (fixed or confirmed as non-issues)
- **Bugs Fixed/Verified:** 45+ (fixed or confirmed as non-issues)
---
@ -346,7 +346,7 @@ Based on git history analysis, the following bugs have been FIXED:
- BUG-041: N/A Backup encryption silently disabled - actually reasonable (S3_BACKUP_ENABLED=False when no key)
- BUG-042: Restore scripts don't validate database integrity (`restore_databases.sh:79`)
- BUG-043: ✅ Health check doesn't check dependencies - FIXED (now checks database and Qdrant connections)
- BUG-044: Uvicorn trusts all proxy headers (`docker/api/Dockerfile:63`)
- BUG-044: ✅ Uvicorn proxy headers - FIXED (FORWARDED_ALLOW_IPS now configurable via env var, with secure deployment guidance)
### Code Quality
- BUG-045: 183 unsafe cast() operations (various files)
@ -366,8 +366,8 @@ Based on git history analysis, the following bugs have been FIXED:
- BUG-054: N/A OAuthToken missing Base inheritance - intentional mixin design (used by OAuthState and OAuthRefreshToken)
- BUG-055: ✅ collection_model returns "unknown" - FIXED (now returns None instead of placeholder)
- BUG-056: ✅ Unused "appuser" in Dockerfile - FIXED (removed unused user creation)
- BUG-057: Build dependencies not cleaned up (`docker/api/Dockerfile:7-12`)
- BUG-058: Typos in log messages (`tests/conftest.py:63`)
- BUG-057: ✅ Build dependencies not cleaned up - FIXED (added apt-get purge after pip install in Dockerfile)
- BUG-058: N/A Typos in log messages - no log messages found at referenced location
- BUG-059: MockRedis overly simplistic (`tests/conftest.py:24-46`)
- BUG-060: ✅ Print statement in ebook.py:192 - FIXED (changed to logger.debug)

11
docker/api/Dockerfile
View File

@ -41,6 +41,11 @@ FROM backend-base
COPY src/ ./src/
RUN pip install -e ".[api]"
# Remove build dependencies to reduce image size
RUN apt-get purge -y gcc g++ python3-dev && \
apt-get autoremove -y && \
rm -rf /var/lib/apt/lists/*
# Copy frontend build output from frontend stage
COPY --from=frontend-builder /frontend/dist ./static/
@ -57,6 +62,10 @@ USER kb
# Set environment variables
ENV PORT=8000
# FORWARDED_ALLOW_IPS controls which IPs can set X-Forwarded-* headers
# Set to specific proxy IPs in production (e.g., "10.0.0.1,10.0.0.2")
# Default "*" is for development/containerized deployments behind trusted proxies
ENV FORWARDED_ALLOW_IPS="*"
EXPOSE 8000
CMD ["uvicorn", "memory.api.app:app", "--host", "0.0.0.0", "--port", "8000", "--proxy-headers", "--forwarded-allow-ips", "*"]
CMD uvicorn memory.api.app:app --host 0.0.0.0 --port 8000 --proxy-headers --forwarded-allow-ips "$FORWARDED_ALLOW_IPS"